Skip to content

Commit

Permalink
brcm63xx: fix an OOPS when accessing the basemode register on 6368
Browse files Browse the repository at this point in the history
The bcm6368 pinctrl driver passed the wrong variable to
devm_regmap_field_alloc, causing it to blow up when later trying to
access the field.

Fixes lede-project#1211.

Signed-off-by: Jonas Gorski <[email protected]>
  • Loading branch information
KanjiMonster committed Dec 13, 2017
1 parent ef1f609 commit a8d3d51
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ Signed-off-by: Jonas Gorski <[email protected]>
+ if (!pctl)
+ return -ENOMEM;
+
+ pctl->overlay = devm_regmap_field_alloc(&pdev->dev, mode, overlay);
+ pctl->overlay = devm_regmap_field_alloc(&pdev->dev, basemode, overlay);
+ if (IS_ERR(pctl->overlay))
+ return PTR_ERR(pctl->overlay);
+
Expand Down

0 comments on commit a8d3d51

Please sign in to comment.