Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add presence for cqc #24

Open
norohind opened this issue May 7, 2021 · 4 comments · May be fixed by #31
Open

Feature request: add presence for cqc #24

norohind opened this issue May 7, 2021 · 4 comments · May be fixed by #31

Comments

@norohind
Copy link

norohind commented May 7, 2021

There is no right way to see if player in cqc from game journals. But I can suggest a few indirect ways:

  1. LoadGame event without Ship field happening on enter in cqc from main menu (can be used to detect enter in cqc)
  2. Music event with "MusicTrack":"MainMenu" happening when exit from cqc to main menu (can be used to detect exit from cqc)
@norohind
Copy link
Author

norohind commented May 8, 2021

Now it is impossible because EDMC don't pass any events when you are in CQC, so we have to hope that journal_entry_cqc() plugin function will be implemented in EDMC

@jlabeeuw
Copy link

jlabeeuw commented May 8, 2021

yes, using the music tracks is a way to check if the cqc is running:
entry['MusicTrack'] in ['CQC']:
==>Means, CQC is active (game running)
entry['MusicTrack'] in ['NoTrack','Exploration', 'Combat_Dogfight']:
==>Means: CQC is still active (no state change)
entry['MusicTrack'] in ['CQCMenu']
==>CQC menu.. queing up...
and otherwise:
==> No CQC

@SayakMukhopadhyay
Copy link
Member

Thanks for the feature request. I will need to test out the above methods and see what fits the best and if they are reliable I will add this feature

@norohind
Copy link
Author

Since journal_entry_cqc EDMC functionality is merged to develop, we can expect it appearance in 5.2.0 EDMC version and then there will be no obstacles to implement this feature request. I already have modified plugin and going to PR it once EDMC 5.2.0 will be released.

@norohind norohind linked a pull request Jan 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants