Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable scanners that are connected while scan in progress #6

Closed
4 tasks done
Erik-White opened this issue Dec 20, 2019 · 1 comment
Closed
4 tasks done

Disable scanners that are connected while scan in progress #6

Erik-White opened this issue Dec 20, 2019 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@Erik-White
Copy link
Owner

Erik-White commented Dec 20, 2019

Scanners are enabled by default when added to the ScannerDevices collections. This opt-out behaviour is usually beneficial as it is unlikely that there will be connected scanners that will not be used. However, devices that are connected after a scan timer has already been started were not 'approved' by the user to be part of the scanning operation.

  • Scanners should be enabled by default when connected

  • Scanners that are already part of the collection should use the existing enabled/disabled state for that scanner when connected

  • Scanners that are connected during scanning should be disabled by default

@Erik-White Erik-White added bug Something isn't working enhancement New feature or request labels Dec 20, 2019
Erik-White added a commit that referenced this issue Feb 24, 2020
Implements user configuration options with an easy to use interface.
Adds basic support for #11 by enabling user specified resolution settings

Closes #5 and #6
@Erik-White
Copy link
Owner Author

Implemented in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant