Adnuntius: Copy advertiserDomains to ORTB bid response adomain (prebid#4113)

Author: antosarho

adapters/adnuntius/adnuntius.go

@@ -54,15 +54,16 @@ type Ad struct {
 	GrossBid struct {
 		Amount float64
 	}
-	DealID          string `json:"dealId,omitempty"`
-	AdId            string
-	CreativeWidth   string
-	CreativeHeight  string
-	CreativeId      string
-	LineItemId      string
-	Html            string
-	DestinationUrls map[string]string
-	Advertiser      adnAdvertiser `json:"advertiser,omitempty"`
+	DealID            string `json:"dealId,omitempty"`
+	AdId              string
+	CreativeWidth     string
+	CreativeHeight    string
+	CreativeId        string
+	LineItemId        string
+	Html              string
+	DestinationUrls   map[string]string
+	AdvertiserDomains []string
+	Advertiser        adnAdvertiser `json:"advertiser,omitempty"`
 }
 
 type AdUnit struct {
@@ -458,13 +459,6 @@ func generateAdResponse(ad Ad, imp openrtb2.Imp, html string, request *openrtb2.
 		}}
 	}
 
-	adDomain := []string{}
-	for _, url := range ad.DestinationUrls {
-		domainArray := strings.Split(url, "/")
-		domain := strings.Replace(domainArray[2], "www.", "", -1)
-		adDomain = append(adDomain, domain)
-	}
-
 	bid := openrtb2.Bid{
 		ID:      ad.AdId,
 		ImpID:   imp.ID,
@@ -476,7 +470,7 @@ func generateAdResponse(ad Ad, imp openrtb2.Imp, html string, request *openrtb2.
 		CrID:    ad.CreativeId,
 		Price:   price * 1000,
 		AdM:     html,
-		ADomain: adDomain,
+		ADomain: ad.AdvertiserDomains,
 		Ext:     extJson,
 	}
 	return &bid, nil

adapters/adnuntius/adnuntiustest/exemplary/simple-banner.json

@@ -59,6 +59,7 @@
                                     "destinationUrls": {
                                         "url": "http://www.google.com"
                                     },
+                                    "advertiserDomains": ["google.com"],
                                     "bid": {
                                         "amount": 20.0,
                                         "currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-dealId.json

@@ -59,6 +59,7 @@
                                   "destinationUrls": {
                                       "url": "http://www.google.com"
                                   },
+                                  "advertiserDomains": ["google.com"],
                                   "bid": {
                                       "amount": 20.0,
                                       "currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-dsa-advertiser-legalName-omitted.json

@@ -78,6 +78,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-dsa-advertiser-legalName.json

@@ -78,6 +78,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-dsa-advertiser-omitted.json

@@ -78,6 +78,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-gdpr.json

@@ -68,6 +68,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-gross-bids.json

@@ -61,6 +61,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": { "amount": 20.0, "currency": "NOK" },
 									"grossBid": {"amount": 0.1, "currency": "NOK"},
 									"netBid": {"amount": 0.075, "currency": "NOK"},

adapters/adnuntius/adnuntiustest/supplemental/check-net-bids.json

@@ -61,6 +61,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": { "amount": 20.0, "currency": "NOK" },
 									"grossBid": {"amount": 0.1, "currency": "NOK"},
 									"netBid": {"amount": 0.075, "currency": "NOK"},

adapters/adnuntius/adnuntiustest/supplemental/check-noCookies-parameter.json

@@ -61,6 +61,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-noCookies.json

@@ -65,6 +65,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-order-multi-imp.json

@@ -84,6 +84,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"
@@ -106,6 +107,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/check-userId.json

@@ -60,6 +60,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/empty-regs-ext.json

@@ -63,6 +63,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/empty-regs.json

@@ -62,6 +62,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/height-error.json

@@ -60,6 +60,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/max-deals-test.json

@@ -67,6 +67,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"cpm": {
 										"amount": 1.0,
 										"currency": "NOK"
@@ -104,6 +105,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 0.001,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/send-header-information.json

@@ -80,6 +80,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/site-ext.json

@@ -70,6 +70,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/size-check.json

@@ -58,6 +58,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/test-networks.json

@@ -60,6 +60,7 @@
 																	"destinationUrls": {
 																			"url": "http://www.google.com"
 																	},
+																	"advertiserDomains": ["google.com"],
 																	"bid": {
 																			"amount": 20.0,
 																			"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/user-ext.json

@@ -69,6 +69,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"

adapters/adnuntius/adnuntiustest/supplemental/width-error.json

@@ -60,6 +60,7 @@
 									"destinationUrls": {
 										"url": "http://www.google.com"
 									},
+									"advertiserDomains": ["google.com"],
 									"bid": {
 										"amount": 20.0,
 										"currency": "NOK"