Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling modification of songs in common across simultaneous players #97

Open
Whuppee opened this issue Oct 29, 2022 · 0 comments
Open
Assignees
Labels
question Further information is requested

Comments

@Whuppee
Copy link

Whuppee commented Oct 29, 2022

notes from a conversation a month ago, as best I remember =p

rarely, someone might remap a track (or more rarely, remove) while someone else is listening to it

since remapping/removing a song doesn't push the change to all queues (and this would be undesirable), the change on the back end is invisible, and querying the db before every play means that the change is made visible only when the intended song is replaced without warning/if removed, however we handle the db having no match for it.

our querying the db before every play was originally/mostly? a lazy way to not have to update duplicates on remap, and assumed that the most up-to-date version would be the one desired. this no longer holds, and currently we don't want to do per-user overrides or handling across the shared queue/stashing, internal playlists and such

instead, seeing as the queue already has all of the needed information to create the audio resource and embeds and is more likely to be what the user requested and expects, we will remove the db calls from play. remap/remove will change the db and effect subsequent retrievals, but should otherwise only modify the queue of whoever issued the command.

between or across long sessions, this could result in repeated remaps by either party. it may not be the best user experience, but the incidence is expected to be low, remap permission could be more gated by roles, and we've worked around this somewhat already in our decision to allow for directly linked youtube resources to persist in stashes and internal playlists

@Whuppee Whuppee self-assigned this Oct 29, 2022
@Whuppee Whuppee added the question Further information is requested label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant