Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard players does not get updated upon joining a server #16

Closed
Goldenschmidt opened this issue Jan 29, 2023 · 7 comments
Closed

Standard players does not get updated upon joining a server #16

Goldenschmidt opened this issue Jan 29, 2023 · 7 comments
Assignees
Labels
bug Something isn't working needs more info This issue is missing crucial information and cannot be fixed until it is provided.

Comments

@Goldenschmidt
Copy link

What happens?
When a player joins a server, and finds a player who is supposedly in Spirit state, they will just see the standard form of the player.
Only way to update this, is for the spirit player to be set themselves as True with the command. No need to set False first.

How do I cause it?
Be in a server with the mod. Set your own state to Spirit. Let a friend join and look at you.

Is this bug so bad that you find it nearly impossible to play?
Nope. Not that big of an issue.

Log file
None available at this time of writing.

@Goldenschmidt Goldenschmidt added the bug Something isn't working label Jan 29, 2023
@EtiTheSpirit
Copy link
Owner

I can't reproduce this error.

I tested this in three ways:

  1. Joined a friend in another dimension by going to that dimension
  2. Joined a friend while standing next to them
  3. Left the server after going away from my friend (out of entity range), rejoined, and walked back to them

In all cases, we saw each other as spirits. Perhaps there is another cause, or some factor I am missing?

@Goldenschmidt
Copy link
Author

That, or it could be another mod interfering..
Did find one mod that would crash the client if you as much as had the Hardlight shield in your inventory. Shield Expansion.

I will run more test with this issue. (Not the one I just mentioned, of course)

@EtiTheSpirit EtiTheSpirit added the needs more info This issue is missing crucial information and cannot be fixed until it is provided. label Jan 29, 2023
@EtiTheSpirit
Copy link
Owner

Yeah there is a good chance its other mods (or out of date versions) causing incompatibility. I ended up testing the latest build of Shield Expansion in my dev environment and it worked fine, the only error is that the hit sound did not work properly.

@Goldenschmidt
Copy link
Author

Yeah there is a good chance its other mods (or out of date versions) causing incompatibility. I ended up testing the latest build of Shield Expansion in my dev environment and it worked fine, the only error is that the hit sound did not work properly.

Yup. Added a new issue, regarding this. #17

@Goldenschmidt
Copy link
Author

Goldenschmidt commented Jan 29, 2023

I can't reproduce this error.

I tested this in three ways:

1. Joined a friend in another dimension by going to that dimension

2. Joined a friend while standing next to them

3. Left the server after going away from my friend (out of entity range), rejoined, and walked back to them

In all cases, we saw each other as spirits. Perhaps there is another cause, or some factor I am missing?

It happened again.
If you couldn't reproduce it with just the Spirit mod alone, it must be something with a mod included.
Will do more testing with it. But will take some time to find the culprit, with the limitations I'm having. If I had another account at my disposal, I could do this at lightning speed.

@EtiTheSpirit
Copy link
Owner

For time time being I am going to close this issue, given that I can't reproduce it at all. If it occurs again, please leave a comment here and I can reopen it.

@EtiTheSpirit EtiTheSpirit closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2023
@Goldenschmidt
Copy link
Author

For time time being I am going to close this issue, given that I can't reproduce it at all. If it occurs again, please leave a comment here and I can reopen it.

Apparently, with 2.0.1., this does no longer happen. So.. you must've fixed it somehow.
Friend reported seeing me in my spirit form, even if I never used the command to set my state.
So... guess it was fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info This issue is missing crucial information and cannot be fixed until it is provided.
Projects
None yet
Development

No branches or pull requests

2 participants