Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimmed videos temporarily un-dim during "inline playback" #161

Open
netjeff opened this issue Jun 11, 2023 · 5 comments
Open

Dimmed videos temporarily un-dim during "inline playback" #161

netjeff opened this issue Jun 11, 2023 · 5 comments

Comments

@netjeff
Copy link
Contributor

netjeff commented Jun 11, 2023

YT recently added an "inline playback" feature: When you hover, the thumbnail is replaced with the actual video playback. YT has a new setting to control inline playback, in "Settings", "Playback and Performance", "Browsing". Turning off inline playback restores the "auto-preview" feature, that shows a few seconds of playback on hover.

During the new inline playback, the video is un-dimmed. When you move the pointer away, the inline playback stops, and the video returns to dimmed. During the "auto preview" the video remains dimmed.

It would be nice if the videos remained dimmed even during inline playback (just like auto-preview). Often I unintentionally hover over watched/dimmed videos. I don't mind that YT starts playback, but the un-dimming catches my eye. So would be nice if the video remained dimmed during inline playback.

For me, I've turned off the new inline playback. But other's might like to keep it on, and yet still have dimmed videos remain dimmed during inline playback.

@netjeff
Copy link
Contributor Author

netjeff commented Jun 11, 2023

I tried changing the 'dimmed' styles ...

.YT-HWV-WATCHED-HIDDEN { display: none !important }
.YT-HWV-WATCHED-DIMMED { opacity: 0.3 }
.YT-HWV-SHORTS-HIDDEN  { display: none !important }
.YT-HWV-SHORTS-DIMMED  { opacity: 0.3 }

... to add a !important like the 'hidden' styles. But videos still un-dim during inline playback.

Keeping the videos dimmed during inline playback is probably going to take more work.

@EvHaus
Copy link
Owner

EvHaus commented Jun 11, 2023

It would be nice if the videos remained dimmed even during inline playback (just like auto-preview).

I'm not sure I agree. I think if the user is actively hovering over a video, they intend to watch the preview. So un-dimming it during auto-preview makes sense to me.

@netjeff
Copy link
Contributor Author

netjeff commented Jun 16, 2023

if the user is actively hovering over a video, they intend to watch the preview.

Agreed that if they are intentionally (actively) hovering. My complaint is about unintentional hovering. I often use mouse scroll wheel to browse up & down. So I leave the pointer in the middle of the window. Then as I scroll with mousewheel, the pointer is unintentionally hovering, triggering unintentional playback.

Agreed that this is minor complaint. Combined with the likely difficulty of hooking into the pop-up to dim it, this is pretty low on my todo list.

If I were to make an attempt someday about unintentional playback... You make a good point about people who intentionally hover for the playback. Probably there would need to be a setting (now that we have settings) whether inline playback remains dimmed. Or maybe a delay setting, so that the video remains dimmed for a second-ish?

@EvHaus
Copy link
Owner

EvHaus commented Jun 19, 2023

For me, YouTube only shows the preview if you hover over the item and wait about 2 seconds. If you're just moving your mouse quickly -- nothing happens:

dim

Are you seeing something different?

@netjeff
Copy link
Contributor Author

netjeff commented Jun 19, 2023

Playback appears instantly for me. Could be a difference in speed/latency?

In your capture a "spinning icon" appears instantly, and then a bit later the full video starts playing. In my case the video just appears. Differences in speed/latency could be due to local PC (cpu, other apps, etc), other plugins/usersrcipts running, ISP speed, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants