Skip to content

Evaneos/front-config

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

48 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Monorepo for Evaneos's front configs

This monorepo provides 3 packages as Evaneos's configs for front projects.

What they do

They setup lints, and formats, and configures your TypeScript/JavaScript code based on Evaneos' practices. Feel free to override the rules that make sense for you.

Installing

Please check either package for detailed README files:

How this works

Eslint

By default, we use env.brower = true but you might want to set env.node = true if that applies to your situation.

Prettier

Prettier might be configured at 2 different places (see "How to install"s for details) :

  • in the package.json
    This is the preferred way at it does not contribute to the growing size of root folders in projects.
  • in a .prettierrc.js
    That would allow overriding its rules

To activate prettier on your projects, you just have to set up those configs and activate it in your IDE.
For example in PHPStorm search for "prettier" and activate the "Automatic Prettier configuration"

Also, you might want to make it autorun when you save a file.
For example in PHPStorm search for "prettier" and check "Run on save".

Understanding our config

For list and the default values of the available configs, you can refer to prettier documentation.

We chose to override those :

  • tabWidth: 4
    Makes the code easier to read
  • singleQuote: true
    We think doubleQuote might be (just a bit) better, but it would generate a lot of changes, so it would not be worth it.

What's important is for every project to have prettier enabled. It doesn't really matter if some projects have little changes over it (eg: printWidth being defaulted to 80);

About printWidth :

It is not the hard upper allowed line length limit. It is a way to say to Prettier roughly how long you’d like lines to be. Prettier will make both shorter and longer lines, but generally strive to meet the specified printWidth.

TSconfig

tsconfig.json is mandatory for a TypeScript project to work.
Some of its config is project specific, but we can share most ot the compilerOptions configs, and so we chose to override some of the defaults :

compilerOptions.target is set to es6 because TSC transpiles poorly to ES5, so we let TSC transpile to ES6 and Babel transpile from ES6 to the desired target.

compilerOptions.module must not be esnext: too risky because it means it auto updates to the last version, while es2020 match our needs.

compilerOptions.moduleResolution defaults to node if module > es6 (es2020 > es6 so => node)

compilerOptions.jsx we prefer to specify the import of React package, because it makes the code less dependent on the tooling.

compilerOptions.useUnknownInCatchVariables default to true because compilerOptions.strict is true and in JavaScript you can catch any type of variables so the caught variable type is unknown.

Contributing

Eslint

You have to keep prettier as the last of eslint extensions. Because it must have the last word on automatic code modification (eg: eslint --fix / prettier).

That is for (at least) 2 reasons :

  • Some rules might overlap between eslint and prettier configs (eg: Arrow Function Parentheses)
  • Prettier must be the ruler of writing style while eslint is the ruler of semantics and other stuff
module.exports = {
    ...,
    extends: [
        'my rules',
        '...',
        'prettier'
    ],
};

Questions / To Discuss in front chapter

Eslint

  • arrow-body-style rule: do we want to force it or not?
    • inline
      • pour debugger soit réécrire les accolade et le return
      • le return est implicite et lors d'un refacto, on ne sait pas facilement quelle était l'intention de la fonction

off la rend flexible always autofix avec eslint --fix

const toto = () => {
  return 'tata';
}

const totso = (param): 'toto' => 'tata';

Notes

We did not settup a default babel configuration because we found it too complex to harmonize between apps (b2b / b2c / next defaults). For now, just look up for existing projects to configure new ones.