Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying external macros file stopped working in v1.1.0 #28

Closed
raulpardo opened this issue Dec 5, 2017 · 3 comments
Closed

Specifying external macros file stopped working in v1.1.0 #28

raulpardo opened this issue Dec 5, 2017 · 3 comments
Assignees
Labels

Comments

@raulpardo
Copy link
Contributor

raulpardo commented Dec 5, 2017

After the latest update specifying a macro file always throws an exception.

In this line

const macroFile = path.join(bufferFileDir, match[0])

match[0] should be match[1] to only get the file name. However, after changing this, the call to the function readFile() in the following line still throws an exception (even though the path is correct)

macroFileText = await readFile(macroFile, 'utf-8')

Any ideas why?

@Evpok Evpok self-assigned this Dec 5, 2017
@Evpok Evpok added the bug label Dec 5, 2017
@Evpok
Copy link
Owner

Evpok commented Dec 5, 2017

Yes, mostly because I am an idiot. I found the error, currently fixing it.

@Evpok
Copy link
Owner

Evpok commented Dec 5, 2017

Fixed by 4bd5e98 (at least WORKSFORME)

Btw, if you had time to write tests for that functionality, that would be greatly appreciated ;)

@Evpok Evpok closed this as completed Dec 5, 2017
@raulpardo
Copy link
Contributor Author

I've written a simple test to check it, see #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants