-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 3.0 to use module-info.java
directly (and not via Moditect)
#1380
Comments
I think module-info.class needs to be put in META-INF/versions/11 (or 9). I'm not sure if fb5ad1b would do that. |
Not sure why -- minimum JDK for master/3.0 is JDK 17. Do you have a link to something that explains possible reasons to do so? (docs I saw just talked about But either way I think it's shade plugin that is somehow filtering/not-copying module-info.class, regardless of where it needs to go. |
You are probably right - that the module-info.class only needs to be in META-INF/versions when you still support Java 8. |
module-info.java
directly, remove use of Moditectmodule-info.java
directly (and not via Moditect)
In Jackson 2.x we use Moditect plugin to add
module-info.class
, instead of relying onjavac
. This because build is done using JDK 8 which cannot handlemodule-info.java
.But with Jackson 3.0 using JDK 17 or above we can and should convert.
NOTE: all modules should do this, except for
jackson-annotations
which remains JDK 8 built for now.The text was updated successfully, but these errors were encountered: