Skip to content
This repository has been archived by the owner on Aug 25, 2018. It is now read-only.

Consider allowing leading underscores in directory names #85

Open
igorwwwwwwwwwwwwwwwwwwww opened this issue Jan 1, 2017 · 3 comments · May be fixed by #91
Open

Consider allowing leading underscores in directory names #85

igorwwwwwwwwwwwwwwwwwwww opened this issue Jan 1, 2017 · 3 comments · May be fixed by #91

Comments

@igorwwwwwwwwwwwwwwwwwwww

I recently ran into a case of a package that would install fine via go get having unexpected behaviour when installing via gvt fetch. It turned out that the package I was trying to install had a directory starting with _ which gvt removes as per this logic.

This was rather unexpected, especially considering go get does not have an issue with it. I have opened a ticket with the project in question openzipkin-contrib/zipkin-go-opentracing#42 but also wanted to inquire if gvt should be a bit more permissive in this case -- as it is rather likely that other packages will have the same issue.

Regards,
Igor

@igorwwwwwwwwwwwwwwwwwwww
Copy link
Author

Quoting @basvanbeek in the ticket linked above:

As all the code under _thrift is generated I specifically prefixed with _ so it would not be included in tests, coverage, linting, etc.

Seems GVT includes omitting behavior to extend to pulling in code too which is rather strange as one would expect the VC to not include items that should be ignored.

If you agree, perhaps gvt could be more permissive in which files it removes?

@Lyoness
Copy link

Lyoness commented Jan 18, 2017

Bump. 🌷 @FiloSottile

@hiroshi
Copy link

hiroshi commented Apr 7, 2017

Hi,
I forked a patch version to address this issue.
See #91

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants