-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the addon changes the fonts of the application #4
Comments
Blocked by #5 |
Confirmed |
Is this issue being investigated? Because it is still an issue with the latest version (2.3.0). Which is a shame because it looks really useful. I did some digging and when I include the addon to my build, the default font that is displayed is Roboto: So something in the addon or its dependecies must be changing the default font type. I investigated a bit further and it seems that the roboto font is prefered over Segoe but it is not loaded until I ad your addon. Upon adding it in the generated html it states: When searching in my project files I find this URL only in typography.js of the vaadin-material-style node module: So maybe something puts the polymerSkipLoadingFontRoboto to false or something else is including this url. |
I did some research on this issue and I see that
is added because paper-chip.js has an import to @polymer/paper-styles/paper-styles.js and this one has an import to typography.js. This typography.js has an import to @polymer/font-roboto/roboto.js and it's this one who adds the <link ....> part cause if (!window.polymerSkipLoadingFontRoboto) {
const link = document.createElement('link');
link.rel = 'stylesheet';
link.type = 'text/css';
link.crossOrigin = 'anonymous';
link.href =
'https://fonts.googleapis.com/css?family=Roboto+Mono:400,700|Roboto:400,300,300italic,400italic,500,500italic,700,700italic';
document.head.appendChild(link);
} According to this paper-styles issue one solution will be to set |
It seems that adding this addon introduces a change in font size in the application as shown in the following image:
The text was updated successfully, but these errors were encountered: