From 54c5b1ad355196925d090ffd6e08f44a8bb13463 Mon Sep 17 00:00:00 2001
From: Petr Skoda <commits@skodak.org>
Date: Sun, 15 Apr 2012 19:40:07 +0200
Subject: [PATCH] MDL32392 delete unused is_min_version() in some DB drivers

---
 lib/dml/mssql_native_moodle_database.php  | 13 -------------
 lib/dml/oci_native_moodle_database.php    | 13 -------------
 lib/dml/pgsql_native_moodle_database.php  |  3 +--
 lib/dml/sqlsrv_native_moodle_database.php | 13 -------------
 4 files changed, 1 insertion(+), 41 deletions(-)

diff --git a/lib/dml/mssql_native_moodle_database.php b/lib/dml/mssql_native_moodle_database.php
index 212f44fccf25e..028538c4f2eea 100644
--- a/lib/dml/mssql_native_moodle_database.php
+++ b/lib/dml/mssql_native_moodle_database.php
@@ -287,19 +287,6 @@ public function get_server_info() {
         return $info;
     }
 
-    /**
-     * Returns if the RDBMS server fulfills the required version
-     *
-     * @param string $version version to check against
-     * @return bool returns if the version is fulfilled (true) or no (false)
-     * @todo Delete this unused and protected method. MDL-32392
-     */
-    protected function is_min_version($version) {
-        $server = $this->get_server_info();
-        $server = $server['version'];
-        return version_compare($server, $version, '>=');
-    }
-
     /**
      * Converts short table name {tablename} to real table name
      * supporting temp tables (#) if detected
diff --git a/lib/dml/oci_native_moodle_database.php b/lib/dml/oci_native_moodle_database.php
index 046e377550d2e..08df721afd272 100644
--- a/lib/dml/oci_native_moodle_database.php
+++ b/lib/dml/oci_native_moodle_database.php
@@ -296,19 +296,6 @@ public function get_server_info() {
         return $info;
     }
 
-    /**
-     * Returns if the RDBMS server fulfills the required version
-     *
-     * @param string $version version to check against
-     * @return bool returns if the version is fulfilled (true) or no (false)
-     * @todo Delete this unused and protected method. MDL-32392
-     */
-    protected function is_min_version($version) {
-        $server = $this->get_server_info();
-        $server = $server['version'];
-        return version_compare($server, $version, '>=');
-    }
-
     /**
      * Converts short table name {tablename} to real table name
      * supporting temp tables ($this->unique_session_id based) if detected
diff --git a/lib/dml/pgsql_native_moodle_database.php b/lib/dml/pgsql_native_moodle_database.php
index f8367fec694cb..31bf35304cae9 100644
--- a/lib/dml/pgsql_native_moodle_database.php
+++ b/lib/dml/pgsql_native_moodle_database.php
@@ -262,9 +262,8 @@ public function get_server_info() {
      *
      * @param string $version version to check against
      * @return bool returns if the version is fulfilled (true) or no (false)
-     * @todo Make this method private. MDL-32392
      */
-    protected function is_min_version($version) {
+    private function is_min_version($version) {
         $server = $this->get_server_info();
         $server = $server['version'];
         return version_compare($server, $version, '>=');
diff --git a/lib/dml/sqlsrv_native_moodle_database.php b/lib/dml/sqlsrv_native_moodle_database.php
index 996b4e857cd78..b2b0e6066a1b0 100644
--- a/lib/dml/sqlsrv_native_moodle_database.php
+++ b/lib/dml/sqlsrv_native_moodle_database.php
@@ -276,19 +276,6 @@ public function get_server_info() {
         return $info;
     }
 
-    /**
-     * Returns if the RDBMS server fulfills the required version
-     *
-     * @param string $version version to check against
-     * @return bool returns if the version is fulfilled (true) or no (false)
-     * @todo Delete this unused and protected method. MDL-32392
-     */
-    protected function is_min_version($version) {
-        $server = $this->get_server_info();
-        $server = $server['version'];
-        return version_compare($server, $version, '>=');
-    }
-
     /**
      * Override: Converts short table name {tablename} to real table name
      * supporting temp tables (#) if detected