diff --git a/galata/test/documentation/extension_manager.test.ts b/galata/test/documentation/extension_manager.test.ts index 9a744d980d82..ccd96c702f73 100644 --- a/galata/test/documentation/extension_manager.test.ts +++ b/galata/test/documentation/extension_manager.test.ts @@ -87,7 +87,7 @@ test.describe('Extension Manager', () => { await openExtensionSidebar(page); await page.fill( - '.jp-extensionmanager-view >> [placeholder="Search"]', + '.jp-extensionmanager-view >> [placeholder="Search extensions"]', 'drawio' ); diff --git a/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-default-documentation-linux.png b/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-default-documentation-linux.png index 4b5f9e014183..5451510789c7 100644 Binary files a/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-default-documentation-linux.png and b/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-default-documentation-linux.png differ diff --git a/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-disabled-documentation-linux.png b/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-disabled-documentation-linux.png index ae606dd0fb51..9b89bd73ce7e 100644 Binary files a/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-disabled-documentation-linux.png and b/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-disabled-documentation-linux.png differ diff --git a/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-enabled-documentation-linux.png b/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-enabled-documentation-linux.png index 4e57c3bd4535..db7ed1559a01 100644 Binary files a/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-enabled-documentation-linux.png and b/galata/test/documentation/extension_manager.test.ts-snapshots/extensions-enabled-documentation-linux.png differ diff --git a/galata/test/jupyterlab/sidebars.test.ts-snapshots/opened-sidebar-extensionmanager-main-view-jupyterlab-linux.png b/galata/test/jupyterlab/sidebars.test.ts-snapshots/opened-sidebar-extensionmanager-main-view-jupyterlab-linux.png index fdfa55630e4d..c54bc8ec04c7 100644 Binary files a/galata/test/jupyterlab/sidebars.test.ts-snapshots/opened-sidebar-extensionmanager-main-view-jupyterlab-linux.png and b/galata/test/jupyterlab/sidebars.test.ts-snapshots/opened-sidebar-extensionmanager-main-view-jupyterlab-linux.png differ diff --git a/packages/codeeditor/package.json b/packages/codeeditor/package.json index 27521535730b..203aa0464c25 100644 --- a/packages/codeeditor/package.json +++ b/packages/codeeditor/package.json @@ -44,6 +44,7 @@ "dependencies": { "@codemirror/state": "^6.2.0", "@jupyter/ydoc": "^1.1.1", + "@jupyterlab/apputils": "^4.2.0-alpha.4", "@jupyterlab/coreutils": "^6.1.0-alpha.4", "@jupyterlab/nbformat": "^4.1.0-alpha.4", "@jupyterlab/observables": "^5.1.0-alpha.4", diff --git a/packages/codeeditor/src/lineCol.tsx b/packages/codeeditor/src/lineCol.tsx index 4b47a3ee5848..0ca036cf5ba6 100644 --- a/packages/codeeditor/src/lineCol.tsx +++ b/packages/codeeditor/src/lineCol.tsx @@ -16,6 +16,7 @@ import { } from '@jupyterlab/ui-components'; import React from 'react'; import { CodeEditor } from './editor'; +import { DOMUtils } from '@jupyterlab/apputils'; /** * A namespace for LineFormComponent statics. @@ -60,6 +61,10 @@ namespace LineFormComponent { * Whether the form has focus. */ hasFocus: boolean; + /** + * A generated ID for the input field + */ + textInputId: string; } } @@ -79,7 +84,8 @@ class LineFormComponent extends React.Component< this._trans = this.translator.load('jupyterlab'); this.state = { value: '', - hasFocus: false + hasFocus: false, + textInputId: DOMUtils.createDomID() + '-line-number-input' }; } @@ -106,6 +112,7 @@ class LineFormComponent extends React.Component< > -