Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Evaluate Backpressure In bip_select #139

Open
3 tasks
GGist opened this issue Nov 24, 2017 · 0 comments
Open
3 tasks

Re-Evaluate Backpressure In bip_select #139

GGist opened this issue Nov 24, 2017 · 0 comments

Comments

@GGist
Copy link
Owner

GGist commented Nov 24, 2017

Currently, many modules don't have backpressure implemented, because the relationship between a message coming from the sink, and the n messages produced by that message, going out in the stream, is not well defined.

This also conflicts with the granularity of messages we expect from a client, as too broad, and it could produce a large n, too granular, and we can get it down to the ideal 1:1 ration of sink message to stream message, but that makes it difficult for clients and causes a lot of needless communication.

Instead, we should standardize that perhaps all of these modules keeps a list of messages to go out in the stream, and if that list is above some threshold k, then any messages coming on from the sink, which could produce messages in the stream (or maybe just all messages coming in regardless), will respond with a NotReady if n is currently larger than k to allow clients to drain the stream until n is less than k.

This way, its not really well defined how large n could be, but it makes it easy for clients and implementors, while also injecting some soft backpressure into the system.

  • UtMetadataModule
  • HonestRevealModule
  • StandardSelectModule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant