Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When sending a one-off job, it doesn't look like a filename is created each time. #1148

Open
heyitsmebev opened this issue Jan 26, 2024 · 1 comment
Assignees

Comments

@heyitsmebev
Copy link
Contributor

Who discovered this?

Beverly N

What happened?

I'm noticing within jobs table, original_file_name is missing for some of the one-off jobs. Some one-off jobs filename is stored in the table while other times, it is not. The only difference in steps I took was the template selected.

Environment

staging

What pages did this appear on?

Within the send flow. /service/id/jobs/id

Image

Image

Image

Detail the steps for someone to reproduce

Within the send flow, select template, send one-off message. Try multiple times using different templates.

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

@heyitsmebev heyitsmebev moved this to 📋 New/Needs Review in Notify.gov product board Jan 26, 2024
@terrazoon terrazoon self-assigned this Jan 29, 2024
@terrazoon terrazoon moved this from 📋 New/Needs Review to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Jan 29, 2024
@terrazoon terrazoon moved this to 👀 In review in Notify.gov product board Jan 31, 2024
@terrazoon terrazoon moved this from 👀 In review to ✅ Done in Notify.gov product board Jan 31, 2024
@tdlowden tdlowden moved this from ✅ Done to 🗑 For archiving in Notify.gov product board Feb 1, 2024
@terrazoon terrazoon moved this to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Feb 26, 2024
@terrazoon
Copy link
Contributor

It looks like the original fix handled most use cases, but there's a case where you first create a template where this still happens. There's some kind of lag causing job.original_file_name not to populate before the page is displayed.

@terrazoon terrazoon moved this from 🏗 In progress (WIP: ≤ 3 per person) to 👀 In review in Notify.gov product board Feb 28, 2024
@terrazoon terrazoon moved this from 👀 In review to ✅ Done in Notify.gov product board Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants