Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address instability from report download caching #2094

Closed
5 of 6 tasks
ecayer opened this issue Nov 8, 2024 · 3 comments
Closed
5 of 6 tasks

Address instability from report download caching #2094

ecayer opened this issue Nov 8, 2024 · 3 comments
Assignees

Comments

@ecayer
Copy link

ecayer commented Nov 8, 2024

In order to improve report performance, the team initially implemented a cache, but this isn't working. We are going to replace the cache with an approach that separates out report generation from downloading in the UI.

For more details on the problem and proposed approach, see here the ADR to Improve API stability when processing job data and generating reports

A full fix for this includes the following fixes and improvements and investigations:

Provisional decision: remove phone numbers. Needs socializing with partners.

@ecayer ecayer converted this from a draft issue Nov 8, 2024
@ecayer
Copy link
Author

ecayer commented Nov 8, 2024

@ccostino Do you have a preference whether we group the work to decouple report generation/download with this or track it in a separate epic? And there isn't yet an issue that includes the UI for that, right?

@ccostino
Copy link
Contributor

@ecayer I think this does need to be split up now at this point... how does this sound?

  • This epic should probably be focused on removing the job cache only.
  • A new epic needs to be created for the report generation itself
  • The UI work... could be a part of the report generation, or it could be its own epic.

For the UI side of all of this you're right, there is no issue yet per se but it's been loosely captured in the ADR. There's been some conversation that's mostly led to more questions and the need for at least some user research.

To me that sounds like a new issue entirely for that, but I figured I'd gut check to be sure! Regardless, if this makes sense, I can help write up some more of the details to help get things more organized with this!

@ecayer
Copy link
Author

ecayer commented Dec 20, 2024

Considering the original epic done, now working on removing phone numbers.

@ecayer ecayer closed this as completed Dec 20, 2024
@github-project-automation github-project-automation bot moved this from Epics - Now to ✅ Done in Notify.gov product board Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants