Skip to content

Commit d0cf059

Browse files
authored
Update versioning strategy (loic-sharma#333)
This replaces `Nerdbank.GitVersioning` with Azure DevOps queue-time variables for versioning. This is a simpler model that should avoid issues like loic-sharma#211 and loic-sharma#135. Part of loic-sharma#57
1 parent cbe96bf commit d0cf059

File tree

2 files changed

+3
-17
lines changed

2 files changed

+3
-17
lines changed

.azure/pipelines/ci-official.yml

-13
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,6 @@ jobs:
4444
inputs:
4545
version: 2.2.100
4646

47-
- task: DotNetCoreCLI@2
48-
displayName: Install versioning tool
49-
inputs:
50-
command: custom
51-
custom: tool
52-
arguments: install --tool-path . nbgv
53-
54-
- script: nbgv cloud
55-
displayName: Run versioning tool
56-
condition: eq(variables['build.sourcebranch'], 'refs/heads/master')
57-
5847
- task: Npm@1
5948
displayName: Install frontend dependencies
6049
inputs:
@@ -80,7 +69,6 @@ jobs:
8069

8170
- script: dotnet pack --configuration $(BuildConfiguration) --output $(Build.ArtifactStagingDirectory)
8271
displayName: Pack
83-
condition: eq(variables['build.sourcebranch'], 'refs/heads/master')
8472

8573
- task: DotNetCoreCLI@2
8674
displayName: Publish
@@ -94,4 +82,3 @@ jobs:
9482
displayName: 'Publish Artifacts'
9583
inputs:
9684
PathtoPublish: '$(Build.ArtifactStagingDirectory)'
97-
condition: eq(variables['build.sourcebranch'], 'refs/heads/master')

src/Directory.Build.props

+3-4
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22

33
<PropertyGroup>
44
<Product>BaGet</Product>
5+
6+
<PackageVersion Condition="'$(PackageVersion)' == ''">0.1.0-prerelease</PackageVersion>
57
<PackageProjectUrl>https://loic-sharma.github.io/BaGet/</PackageProjectUrl>
68
<PackageLicenseExpression>MIT</PackageLicenseExpression>
79
<PackageIconUrl>https://raw.githubusercontent.com/NuGet/Media/master/Images/MainLogo/256x256/nuget_256.png</PackageIconUrl>
10+
811
<RepositoryUrl>https://github.com/loic-sharma/BaGet</RepositoryUrl>
912
<RepositoryType>git</RepositoryType>
1013
<PublishRepositoryUrl>true</PublishRepositoryUrl>
@@ -38,8 +41,4 @@
3841
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta-63127-02" PrivateAssets="All"/>
3942
</ItemGroup>
4043

41-
<ItemGroup Condition="$(IsPackable) == 'true' AND $(DOTNET_RUNNING_IN_CONTAINER) == ''">
42-
<PackageReference Include="Nerdbank.GitVersioning" Version="2.3.105" PrivateAssets="all" />
43-
</ItemGroup>
44-
4544
</Project>

0 commit comments

Comments
 (0)