Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Trimming: Crash due to missing tracks property #12472

Closed
swissspidy opened this issue Oct 13, 2022 · 1 comment
Closed

Video Trimming: Crash due to missing tracks property #12472

swissspidy opened this issue Oct 13, 2022 · 1 comment
Labels
Elements: Video Group: Video Optimization Media transcoding, compression and cropping Type: Bug Something isn't working

Comments

@swissspidy
Copy link
Collaborator

Bug Description

Sometimes the video trimming crashes here:

const tracksFormatted = tracks.map((track) => {
const src = getProxiedUrl(track, track?.track);
return {
...track,
track: src,
};
});

because tracks is undefined.

I have not yet found out how to get tracks to be undefined, but it is the case in this story @kkalarickal created:

https://web-stories.local/wp-admin/post-new.php?post_type=web-story#page=%2522dcf4d19c-60e4-47bc-918a-ce01c5f6cb0a%2522

We should add a data migration to add the missing tracks property and figure out why it's sometimes absent.

Expected Behaviour

No crashes in video trimming

Steps to Reproduce

  1. In the story above, try to trim video on page 5

Screenshots

Additional Context

  • Plugin Version: 1.25.1
  • WordPress Version: 6.0
  • Operating System: macOS
  • Browser: Chrome
@swissspidy swissspidy added Type: Bug Something isn't working Elements: Video Pod: Prometheus Group: Video Optimization Media transcoding, compression and cropping labels Oct 13, 2022
@swissspidy
Copy link
Collaborator Author

Duplicate of #12471

@swissspidy swissspidy marked this as a duplicate of #12471 Oct 13, 2022
@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Elements: Video Group: Video Optimization Media transcoding, compression and cropping Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant