Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: write to disk only when progress updated #839

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

monkeyWie
Copy link
Member

No description provided.

@monkeyWie monkeyWie added the perf Performance optimization label Dec 8, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Project coverage is 58.82%. Comparing base (f4876c8) to head (c55f8d6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/download/downloader.go 39.13% 10 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   58.80%   58.82%   +0.02%     
==========================================
  Files          35       35              
  Lines        4464     4474      +10     
==========================================
+ Hits         2625     2632       +7     
  Misses       1567     1567              
- Partials      272      275       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monkeyWie monkeyWie merged commit 427921c into main Dec 9, 2024
9 of 10 checks passed
@monkeyWie monkeyWie deleted the perf/task_save branch December 9, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant