Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for reader changes to listing 8.5 is confusing #131

Open
pledbrook opened this issue Apr 22, 2015 · 0 comments
Open

Suggestion for reader changes to listing 8.5 is confusing #131

pledbrook opened this issue Apr 22, 2015 · 0 comments
Labels
ch08

Comments

@pledbrook
Copy link
Contributor

The paragraph immediately after listing 8.5 suggests that the reader may want to try testing "minutes ago" and "seconds ago" as an exercise. That's fine for the former, but the current implementation of getNiceDate() doesn't handle "seconds ago". The implication is that the reader only has to work on the test case, but in fact they need to modify the getNiceDate() implementation as well.
@pledbrook pledbrook added the ch08 label Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ch08
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pledbrook