Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions on the number of extra attributes is not updated #123

Closed
zptro opened this issue Nov 30, 2021 · 2 comments
Closed

Instructions on the number of extra attributes is not updated #123

zptro opened this issue Nov 30, 2021 · 2 comments
Assignees

Comments

@zptro
Copy link
Collaborator

zptro commented Nov 30, 2021

| 3 000 000 | words for extra attributes |

@johpiip
Copy link
Contributor

johpiip commented Dec 1, 2021

@zptro, does this code sample take into account that --separate-emme-scenarios is specified for every Helmet scenario and it may be the same for all Helmet scenarios that are being validated? I did not catch this previously while reviewing, sorry!

I mean if the call is something like:

C:\Users\PiippJo\Home\helmet-model-system\Scripts\helmet_validate_inputfiles.py
--log-level
DEBUG
--log-format
JSON
--baseline-data-path
C:\Users\PiippJo\Home\malliajot\01_Lahtodata\Base_input_data_Helmet41_test
--results-path
C:\Users\PiippJo\Home\malliajot\03_Tulokset
--scenario-name
test-helmet406
--emme-paths
C:\Users\PiippJo\Home\malliajot\02_Syottotiedot\v2018.emp
C:\Users\PiippJo\Home\malliajot\02_Syottotiedot\testimock.emp
--first-scenario-ids
24
21
--forecast-data-paths
C:\Users\PiippJo\Home\malliajot\helmet-model-system-v4.0.6-09-06-1625821679232\tests\test_data\Scenario_input_data\2030_test
C:\Users\PiippJo\Home\malliajot\02_Syottotiedot\2030_test

Then we would need something like:

--separate-emme-scenarios
TRUE
FALSE

Which looks weird.

@zptro zptro closed this as completed Dec 17, 2021
@zptro
Copy link
Collaborator Author

zptro commented Dec 17, 2021

This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants