Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax of the project #36

Closed
tmiotto opened this issue Dec 2, 2015 · 8 comments
Closed

Fix syntax of the project #36

tmiotto opened this issue Dec 2, 2015 · 8 comments

Comments

@tmiotto
Copy link
Contributor

tmiotto commented Dec 2, 2015

Rubocop linting is failing and it's spread across almost every file created.

Need to fix the syntax of the merged files failing in Rubocop

@jsmartt
Copy link
Collaborator

jsmartt commented Dec 2, 2015

Hi @tmiotto , are you seeing this on the current master build? If so, what version of rubocop are you running? I'm not seeing this failure, and neither is the Jenkins server.
I'm on Rubocop v0.35.1, which appears to be the latest (see here)

@tmiotto
Copy link
Contributor Author

tmiotto commented Dec 3, 2015

Hi @jsmartt , my Rubocop is the same version as yours (0.35.1) but it's detecting CRLF's in almost each require in the project, and also some unnecessary spaces.

@tmiotto
Copy link
Contributor Author

tmiotto commented Dec 3, 2015

Hello again @jsmartt , I talked with @hdiomede and he has this CRLF problem sometimes, maybe is some inconsistency among the workstations (probably caused by the different OS being used).

I think the carriage return can be solved using a .gitattributes file, but the spacing offenses remain still.

@jsmartt
Copy link
Collaborator

jsmartt commented Dec 3, 2015

Gotcha. After downloading the zip and searching the project for windows line endings, I found only 1 file with them. I'll put up a PR shortly, but I like the .gitattributes file idea, I just don't know exactly what to put in it to get our desired behavior. I think the best behavior would be to mimick git config core.autocrlf input. Would you both agree?

@jsmartt
Copy link
Collaborator

jsmartt commented Dec 3, 2015

I'm thinking we can do this by making a .gitattributes file with:

* text eol=lf

???

@tmiotto
Copy link
Contributor Author

tmiotto commented Dec 3, 2015

Exactly @jsmartt

@jsmartt
Copy link
Collaborator

jsmartt commented Dec 3, 2015

Ok, PR #39 should accomplish this. Once we get this merged in, however, it might be a good idea for everyone to run $ git config --global core.autocrlf input so we always commit lf line endings. The spec/support/fixtures/integration/ethernet_network.json file was my bad

@tmiotto
Copy link
Contributor Author

tmiotto commented Dec 4, 2015

PR #39 is merged.

I recommend following this GitHub Tutorial to apply the .gitattributes modifications to the local project. (the final commit in the tutorial is not necessary since it's already fine on remote)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants