Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers don't wrap on word #367

Closed
nanodeath opened this issue Mar 10, 2021 · 2 comments · Fixed by #369
Closed

Headers don't wrap on word #367

nanodeath opened this issue Mar 10, 2021 · 2 comments · Fixed by #369
Assignees
@nanodeath
Labels
bug Bugs within the program good first issue Issues which are suitable for new contributors
Milestone
2021.1.0-RELEASE

Comments

@nanodeath
Copy link
Contributor

Describe the bug
I'd expect headers to wrap on word, like paragraphs do, but they don't.

To Reproduce
This is enough to repro (from the tutorial):

addComponent(Components.textBox(27)
    .addHeader("Congratulations, you leveled up!")
    .addParagraph("Pick an improvement from the options below:"))

Expected behavior

  • Header to be wrapped on word, even without the old .wrapWithBox() call.

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows 10

Additional context
Add any other context about the problem here.
@nanodeath
Copy link
Contributor Author

I'm going to take a stab at this.

nanodeath added a commit to nanodeath/zircon that referenced this issue Mar 12, 2021
@nanodeath
Make header text wrap on word.
5908dd9 
Closes Hexworks#367.
@nanodeath nanodeath mentioned this issue Mar 12, 2021
Merged
nanodeath added a commit to nanodeath/zircon that referenced this issue Mar 12, 2021
@nanodeath
Make header text wrap on word.
f5a9037 
Closes Hexworks#367.
nanodeath added a commit to nanodeath/zircon that referenced this issue Mar 12, 2021
@nanodeath
Make header text wrap on word.
ed00854 
Closes Hexworks#367.
@adam-arold adam-arold added bug Bugs within the program good first issue Issues which are suitable for new contributors labels Apr 6, 2021
@adam-arold
Copy link
Member

I'm taking a look at your PR now!

nanodeath added a commit to nanodeath/zircon that referenced this issue Apr 8, 2021
@nanodeath
Make header text wrap on word.
5cef8bd 
Closes Hexworks#367.
nanodeath added a commit to nanodeath/zircon that referenced this issue Apr 8, 2021
@nanodeath
Make header text wrap on word.
e820c40 
Closes Hexworks#367.
@adam-arold adam-arold added this to the 2021.1.0-RELEASE milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanodeath nanodeath

Labels
bug Bugs within the program good first issue Issues which are suitable for new contributors
Projects
None yet
Milestone
2021.1.0-RELEASE
Development

Successfully merging a pull request may close this issue.

Update headers to wrap on word, plus test extension functions nanodeath/zircon
2 participants
@nanodeath @adam-arold