Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FILTER_SANITIZE_STRING is deprecated in PHP 8.1 #1159

Closed
fiammybe opened this issue Feb 9, 2022 · 7 comments · Fixed by #1328
Closed

FILTER_SANITIZE_STRING is deprecated in PHP 8.1 #1159

fiammybe opened this issue Feb 9, 2022 · 7 comments · Fixed by #1328
Assignees
@MekDrop
Labels
blocking PHP 8.1
Milestone
ImpressTNG Alpha 13

Comments

@fiammybe
Copy link
Member

fiammybe commented Feb 9, 2022

Describe the bug

the use of FILTER_SANITIZE_STRING is no longer allowed. This creates problems in \core\DataFilter.php
@fiammybe fiammybe added this to the 2.0.0 Alpha 13 milestone Feb 9, 2022
@github-actions
Copy link

This issue was automatically marked as stale

@github-actions github-actions bot added the stale label May 28, 2022
@MekDrop
Copy link
Member

MekDrop commented May 30, 2022

https://stackoverflow.com/a/69207369 possible solutions

@fiammybe fiammybe modified the milestones: 2.0.0 Alpha 13, 2.0.0 Beta 1 May 31, 2022
@skenow
Copy link
Contributor

skenow commented Jul 29, 2022

Perhaps it's time to rethink how we protect against XSS and SQli - our current approach has room for improvement and did cause a few developers to fork (Julian) or create something completely different (Simon).

@skenow skenow removed the stale label Jul 29, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Oct 1, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2022
@fiammybe
Copy link
Member Author

Until we review our filtering strategy (as proposed by @skenow in the chat a few weeks ago) this still needs to be fixed. PHP 8.1 is almost superseded by a new version

@fiammybe fiammybe reopened this Oct 11, 2022
@MekDrop MekDrop removed the stale label Oct 11, 2022
@MekDrop MekDrop self-assigned this Oct 11, 2022
@MekDrop
Copy link
Member

MekDrop commented Oct 11, 2022

I will look into this.

@MekDrop MekDrop modified the milestones: 2.0.0 Beta 1, 2.0.0 Alpha 13 Oct 11, 2022
@MekDrop MekDrop mentioned this issue Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MekDrop MekDrop

Labels
blocking PHP 8.1
Projects
None yet
Milestone
ImpressTNG Alpha 13
Development

Successfully merging a pull request may close this issue.

Fix: FILTER_SANITIZE_STRING is deprecated MekDrop/impresscms
3 participants
@MekDrop @skenow @fiammybe