Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin theme is not taken into consideration in icms_view_Tpl constructor #1551

Open
fiammybe opened this issue Mar 22, 2024 · 1 comment
Open

Comments

@fiammybe
Copy link
Member

fiammybe commented Mar 22, 2024

When your admin theme is different from your frontend theme, the icms_view_Tpl class will always take the value in $icmsConfig['theme_set'] to identify where to look for eventual theme overrides (check out line 70, where the compile_id is constructed.
This could be the reason why the template overrides in a admin theme don't seem to work.
I think this information cannot be determined by the icms_view_Tpl class on its own, it needs input from the calling class.

@fiammybe fiammybe added this to the 2.0.0 (new) milestone Mar 22, 2024
@fiammybe fiammybe modified the milestones: 2.0.0 (new), 2.0.1 Jul 23, 2024
@fiammybe
Copy link
Member Author

fiammybe commented Oct 6, 2024

this does work when you define a template in a template set, instead of adding a template file to a theme. @skenow this boils down again to the discussion what the difference is between template sets and themes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant