Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTMLPurifier to support HTML5 #303

Closed
fiammybe opened this issue Jun 12, 2018 · 7 comments
Closed

Update HTTMLPurifier to support HTML5 #303

fiammybe opened this issue Jun 12, 2018 · 7 comments

Comments

@fiammybe
Copy link
Member

Verify that the values that we have in the ACP are still in line with the values that are supported by HTMLPurifier in its latest version.

@fiammybe fiammybe added this to the v1.3.11 milestone Jun 12, 2018
@fiammybe fiammybe self-assigned this Jun 12, 2018
@fiammybe fiammybe changed the title Update the configuration items for HTMLPurifier Update HTTMLPurifier to support HTML5 Jun 12, 2018
@fiammybe fiammybe modified the milestones: v1.3.11, 2.0.0 alpha8 Jun 12, 2018
@fiammybe
Copy link
Member Author

OK, so I thought that we didn't have HTML5 support in our library because we were behind in what HTMLPurifier could offer, but it turns out that the vanilla HTMLPurifier does not officially support HTML5.

I found this : https://github.com/xemlock/htmlpurifier-html5, which offers a HTML5-compatible HTMLPurifier.

We will have to adapt our declaration of the HTMLPurifier library to match this new one, should we decide to use it.

@fiammybe
Copy link
Member Author

This might even be a good improvement for the 1.3 branch, given that HTML5 isn't that novel anymore and widely usd :-)

@fiammybe fiammybe modified the milestones: 2.0.0 alpha8, 2.1 Dec 18, 2019
@github-actions
Copy link

This issue was automatically marked as stale

@github-actions github-actions bot added the stale label May 28, 2021
@MekDrop MekDrop removed the stale label Oct 11, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Dec 11, 2022
@MekDrop MekDrop removed the stale label Dec 11, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 11, 2023
@MekDrop MekDrop removed the stale label Feb 11, 2023
@fiammybe fiammybe modified the milestones: 2.1, ImpressTNG Alpha 13 Feb 11, 2023
@skenow
Copy link
Contributor

skenow commented Sep 1, 2023

ezyang's HTMLPurifier library does include another library to extend coverage to HTML5 tags - see libraries/htmlpurifier/standalone/Lexer/PH5P.php. The 4.15.0 version has PHP8.1 fixes in this file.

@fiammybe
Copy link
Member Author

in that case, I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants