Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes can have .tpl endings #315

Open
fiammybe opened this issue Jul 10, 2018 · 4 comments
Open

themes can have .tpl endings #315

fiammybe opened this issue Jul 10, 2018 · 4 comments
Assignees

Comments

@fiammybe
Copy link
Member

To identify that the templates are not full HTML files, we should be able to use the .tpl ending for the theme templates.
This makes the extension of the file .html.tpl, so we can see what the template is meant to generate :-)

@fiammybe fiammybe added this to the 2.0.0 alpha8 milestone Jul 10, 2018
@fiammybe fiammybe self-assigned this Jul 10, 2018
@fiammybe fiammybe modified the milestones: 2.0.0 alpha8, 2.1 Dec 18, 2019
@github-actions
Copy link

This issue was automatically marked as stale

@github-actions github-actions bot added the stale label May 28, 2021
@MekDrop MekDrop removed the stale label Oct 11, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Dec 11, 2022
@MekDrop MekDrop removed the stale label Dec 11, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 11, 2023
@MekDrop MekDrop removed the stale label Feb 11, 2023
@fiammybe fiammybe modified the milestones: 2.1, ImpressTNG Alpha 13 Feb 11, 2023
@fiammybe
Copy link
Member Author

I tried to make it work with either .html or .html.tpl extensions, but that was adding lots of checks throughout the code. I propose we simply decide on making the switch to .html.tpl extensions at a certain point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants