Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editors need update to comply with PRS-4 #774

Closed
fiammybe opened this issue Sep 15, 2020 · 6 comments · Fixed by #800
Closed

Editors need update to comply with PRS-4 #774

fiammybe opened this issue Sep 15, 2020 · 6 comments · Fixed by #800
Assignees

Comments

@fiammybe
Copy link
Member

Composer has been warning about PSR-4 compatibility issues for plugins\sourceeditors\codemirror\Editor.php , plugins\sourceeditors\editarea\Editor.php, editors\dhtmltextarea\Editor.php and editors\tinymce\Editor.php

With the imminent composer 2.0 these will no longer work.

@fiammybe fiammybe added the bug label Sep 15, 2020
@fiammybe fiammybe added this to the 2.0.0 Beta 1 milestone Sep 15, 2020
@fiammybe fiammybe self-assigned this Sep 15, 2020
@fiammybe
Copy link
Member Author

The problem is the case of the folders.

@MekDrop
Copy link
Member

MekDrop commented Sep 15, 2020

Will be fixed after I will solve issue with assets copying from editors. Until 2.0 composer we still have enough time I think.

@fiammybe
Copy link
Member Author

composer 2 is in RC-1 :-) that's why I started looking at it. At least I can make the folders in which the files are now correspond with the names of the classes. I did it manually (changes htmltextarea to HTMLTextArea for example) and it worked. Now I only have to get my IDE to accept the name change of the folders and make a PR of it

@MekDrop
Copy link
Member

MekDrop commented Sep 17, 2020

I planned to move editors to separate modules and include them in installer. So, it would be easier to deal with editor updates. But I guess for current time only folders moving could be enough... at least no more composer warnings... :)

@fiammybe
Copy link
Member Author

fiammybe commented Jan 1, 2021

With the fact that we can't support Composer 2 for the time being due to a dependency that isn't compatible with it, this ticket is on hold. #823

@github-actions
Copy link

This issue was automatically marked as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants