Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Use of StopSpammer #82

Open
fiammybe opened this issue Jan 12, 2017 · 7 comments
Open

Improve Use of StopSpammer #82

fiammybe opened this issue Jan 12, 2017 · 7 comments
Assignees
Milestone

Comments

@fiammybe
Copy link
Member

fiammybe commented Jan 12, 2017

Stopspammer is used in the core during the creation of users. In some cases, for example during a local installation, Stopspammer gives false positives, effectively blocking users where it is not needed.

  • reduce false positives
  • make it optional

I think this is a good candidate to use the events in the core : create an event 'beforeusercreate' and link stopspammer to that.

This is an import from Assembla Ticket 431

@fiammybe fiammybe added this to the 2.0.0 milestone Jan 12, 2017
@MekDrop
Copy link
Member

MekDrop commented Feb 12, 2018

#147 is related.

So, was there any progress with this task?

@github-actions
Copy link

This issue was automatically marked as stale

@github-actions github-actions bot added the stale label May 28, 2021
@MekDrop
Copy link
Member

MekDrop commented Oct 11, 2022

@skenow do you still have a plan anything to do with this?

@fiammybe fiammybe removed the stale label Oct 16, 2022
@skenow
Copy link
Contributor

skenow commented Oct 28, 2022

To be honest, I haven't come up with a plan of attack. I'll have a look at it.

@MekDrop
Copy link
Member

MekDrop commented Oct 31, 2022

@skenow I think finding a similar library that is regularly updated would be an excellent first step and then replacing internal StopSpammer code with this library. One of our main problems is that we do not have enough time to keep up with security stuff..

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Dec 31, 2022
@MekDrop MekDrop removed the stale label Dec 31, 2022
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Mar 6, 2023
@MekDrop MekDrop removed the stale label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants