From 72921c663d7df47bfc9b78766366dbfaa55a0915 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Tue, 21 Jul 2015 11:17:08 -0700 Subject: [PATCH] cmd/go: skip TestGoInstallErrorOnCrossCompileToBin in short mode That test will install cmd/pack for linux_386; we don't want to change GOROOT in short mode. Change-Id: I4b00c578a99779a13c558208bfd4115f8f0513fa Reviewed-on: https://go-review.googlesource.com/12481 Run-TryBot: Ian Lance Taylor Reviewed-by: David Crawshaw TryBot-Result: Gobot Gobot --- src/cmd/go/go_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index aebb966b020375..a6353f580f6a06 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -746,6 +746,10 @@ func TestGoInstallDetectsRemovedFiles(t *testing.T) { } func TestGoInstallErrorOnCrossCompileToBin(t *testing.T) { + if testing.Short() { + t.Skip("don't install into GOROOT in short mode") + } + tg := testgo(t) defer tg.cleanup() tg.tempFile("src/mycmd/x.go", `package main