Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam Rank 5 #123

Open
karimomino opened this issue Sep 6, 2023 · 1 comment
Open

Exam Rank 5 #123

karimomino opened this issue Sep 6, 2023 · 1 comment

Comments

@karimomino
Copy link

When ASpell and ATarget dont have virtual destructors the submission fails as expected, however the trace provided is incorrect
Expected :

cpp_module01/main.cpp:21:3: error: delete called on non-final 'Fwoosh' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor]
  delete fwoosh;

Received

<--------------~-~-~-~-~-~-~-~-~------------>
Richard: This looks like another boring day.$
Richard: I am Richard, the Titled!$
Target Practice Dummy has been fwooshed!$
Richard: My job here is done!$
\n
<--------------~-~-~-~-~-~-~-~-~------------>\n\n
<--------------~-~-~-~-~-~-~-~-~------------>
Richard: This looks like another boring day.$
Richard: I am Richard, the Titled!$
Target Practice Dummy has been fwooshed!$
\n
<--------------~-~-~-~-~-~-~-~-~------------>
@SkyHearts
Copy link

The trace doesn't log errors. I kept failing module01, apparently i didn't have to delete the spells in forgetSpell function, only in destructors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants