Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc password generated insecurely #172

Open
BenWestgate opened this issue Jun 29, 2022 · 0 comments
Open

rpc password generated insecurely #172

BenWestgate opened this issue Jun 29, 2022 · 0 comments

Comments

@BenWestgate
Copy link

BenWestgate commented Jun 29, 2022

From
https://github.com/JWWeatherman/yeticold/blob/master/appyeticold.py

v.rpcpsw = str(random.randrange(0,1000000))
v.settings = {"rpc_username": "rpcuser","rpc_password": v.rpcpsw, "rpc_host": "127.0.0.1","rpc_port": 8332,"address_chunk": 100}
v.wallet_template = "http://{rpc_username}:{rpc_password}@{rpc_host}:{rpc_port}/wallet/{wallet_name}"

From
https://docs.python.org/3/library/random.html

Warning

###The pseudo-random generators of this module should not be used for security purposes. For security or cryptographic uses, see the secrets module.

The secrets module should be used for passwords and keys, random is designed to be fast for simulation purposes but can be predicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant