Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust parameters for blob tx and allow passing gas-limit as a param #21

Open
Jesserc opened this issue Mar 18, 2024 · 14 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@Jesserc
Copy link
Owner

Jesserc commented Mar 18, 2024

No description provided.

@Jesserc Jesserc added this to the Features milestone Mar 18, 2024
@danielcdz
Copy link

Hey @Jesserc can I help you with this issue?

@Jesserc
Copy link
Owner Author

Jesserc commented Jun 7, 2024

@danielcdz yes, thanks

@danielcdz
Copy link

Great thank you! can you provide me more context?

@Jesserc
Copy link
Owner Author

Jesserc commented Jun 7, 2024

Right now, some parameters for blob tx are fixed in handleSendBlobTx.go. We can allow some of these params to be passed by the caller. 

I'd also love to add an --rpc-url subcommand to the get-blob command here. so you can look at the flow of others and see how theirs was done, for example in gasprice.go, createRaw.go, etc...

@danielcdz
Copy link

@Jesserc Got it! working on it, I'll let you know if I need something else

@Jesserc Jesserc added enhancement New feature or request good first issue Good for newcomers labels Jun 8, 2024
@danielcdz
Copy link

Hey @Jesserc, I think you forgot to assign me the issue

@Jesserc
Copy link
Owner Author

Jesserc commented Jun 10, 2024

Done, thanks!

@danielcdz
Copy link

Hey @Jesserc I'm pretty busy these next weeks, is this urgent? If it is the case I can leave this to another person

@danielcdz
Copy link

@Jesserc I will leave this issue to another contributor 😢 , a lot of things are happening at this moment and I don't think I can work on this one, I'm sorry...

I'll be looking for issues on this project in the future!

@danielcdz danielcdz removed their assignment Jun 19, 2024
@Jesserc
Copy link
Owner Author

Jesserc commented Jun 19, 2024

@danielcdz no worries, take care!

@krishnateja262
Copy link

@Jesserc would like to take this one up if it is open

@Jesserc
Copy link
Owner Author

Jesserc commented Jun 24, 2024

@krishnateja262 it is!

@krishnateja262
Copy link

ok, will get started working on the it, can you assign it to me

@Villegas2003
Copy link

Hi @Jesserc , Are you still in need of support for this issue? I'd be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants