Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark methods connected to signals as unused #90

Open
XReaper95 opened this issue Jan 5, 2023 · 3 comments
Open

Do not mark methods connected to signals as unused #90

XReaper95 opened this issue Jan 5, 2023 · 3 comments

Comments

@XReaper95
Copy link

Currently, methods that are connected to a signal (through the editor) are marked as unused by Rider:

Screenshot_2023-01-05_11-34-10 (Example from Thrive)

It would be nice to add a feature to show the scene file where the connection is stored and mark it as referenced by Godot or something, like the Unity plugin does.

@van800
Copy link
Member

van800 commented Jan 22, 2023

I think for the Godot 4 this is solved with source generators on the Godot side.

@XReaper95
Copy link
Author

Well, I just did some tests and every single method, even if is empty and unused, is indeed referenced in the generated partial class. But in fact I think is worse because now we basically lost the ability to check what method is really not being used in the project, using that feature. I was thinking of the plugin doing something like Unity does:
example
Then it will link to the tscn file where the link was written. I mean, ideally, it will focus the editor window and highlight the Node with the signal, but I know that will require some work there, so this can be a good first solution.

Of course, the original issue is resolved and at least we won't have a bunch of warnings.

@jking47
Copy link

jking47 commented Oct 30, 2024

EDIT: Actually after testing my error was from the 3rd party gdscript plugin, trying to avoid using that one so uninstalled, but I do have the above users issue with no method being seen as 'unused'. More minor issue for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants