From 7c4b9c8a0d5fd4b8c756fc0d87ece572b3afd78f Mon Sep 17 00:00:00 2001 From: William Casarin Date: Mon, 8 Oct 2018 16:02:02 -0700 Subject: [PATCH] build: fix compile error on gcc ~7.3.0 It seems to be having a bit of trouble understanding the control flow to realize it's not actually uninitialized. Add an error handler after the switch in case we miss a real uninitialized error in the future. Signed-off-by: William Casarin --- devtools/gossipwith.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/devtools/gossipwith.c b/devtools/gossipwith.c index 97962365cae6..75de6a0b1666 100644 --- a/devtools/gossipwith.c +++ b/devtools/gossipwith.c @@ -150,11 +150,11 @@ int main(int argc, char *argv[]) { struct io_conn *conn = tal(NULL, struct io_conn); struct wireaddr_internal addr; - int af; + int af = -1; struct pubkey us, them; const char *err_msg; const char *at; - struct addrinfo *ai; + struct addrinfo *ai = NULL; setup_locale(); secp256k1_ctx = secp256k1_context_create(SECP256K1_CONTEXT_VERIFY | @@ -212,6 +212,10 @@ int main(int argc, char *argv[]) } ai = wireaddr_to_addrinfo(tmpctx, &addr.u.wireaddr); } + + if (af == -1 || ai == NULL) + err(1, "Initializing socket"); + conn->fd = socket(af, SOCK_STREAM, 0); if (conn->fd < 0) err(1, "Creating socket");