Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong mangling for some function signatures #671

Open
Keluaa opened this issue Feb 22, 2025 · 0 comments · May be fixed by #672
Open

Wrong mangling for some function signatures #671

Keluaa opened this issue Feb 22, 2025 · 0 comments · May be fixed by #672

Comments

@Keluaa
Copy link
Contributor

Keluaa commented Feb 22, 2025

The current mangling scheme handles some substitutions incorrectly:

julia> mangled = GPUCompiler.mangle_sig(Tuple{identity, Tuple{Ptr{Int}}, Tuple{Ptr{Int}}})
"_Z8identity5TupleIP5Int64ES1_"

Which unmangles to identity(Tuple<Int64*>, Int64*).

The correct mangled name would have been _Z8identity5TupleIP5Int64ES2_ (identity(Tuple<Int64*>, Tuple<Int64*>)).
Note that it differs only in the S1_/S2_ part.
@Keluaa Keluaa linked a pull request Feb 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some edge cases for mangling Keluaa/GPUCompiler.jl
1 participant
@Keluaa