Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SubscriptionExists #299

Closed
vapaj opened this issue Mar 20, 2020 · 2 comments · Fixed by #361
Closed

Handle SubscriptionExists #299

vapaj opened this issue Mar 20, 2020 · 2 comments · Fixed by #361
Assignees
Labels

Comments

@vapaj
Copy link
Contributor

vapaj commented Mar 20, 2020

While we are checking if the customer already has the subscription in Vetrina, the client side and server side might not be in sync. So handle SubscriptionExists errors we get from Bottega.

@vapaj vapaj added the vetrina label Mar 20, 2020
@ae-mo ae-mo self-assigned this Apr 8, 2020
@ae-mo
Copy link
Contributor

ae-mo commented Apr 15, 2020

@vapaj so after we have the info about a duplicate subscription from bottega, I guess we need to show an error view, correct?

@vapaj
Copy link
Contributor Author

vapaj commented Apr 16, 2020

We need to think about a behaviour for that, it's not really an error from the UX point of view. The simplest solution would be to just close vetrina by calling the onClose prop (at least in this case, where we are embedding it in an article).

@vapaj vapaj assigned vapaj and unassigned ae-mo May 11, 2020
ae-mo pushed a commit that referenced this issue Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants