Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add som extra markers for ads in app article view #316

Closed
pikkuruusu opened this issue Apr 2, 2020 · 4 comments
Closed

Add som extra markers for ads in app article view #316

pikkuruusu opened this issue Apr 2, 2020 · 4 comments

Comments

@pikkuruusu
Copy link
Member

We want to make it a bit clearer that an ad is an ad. So we want to add a line before the ad and move the word "ANNONS" to center. We also want to add line after ad and add the words "ANNONS SLUT".

Example:

image (2)

@lfaz
Copy link

lfaz commented Apr 3, 2020

I think this needs to be redesigned from https://script.ksfmedia.fi/app/gamAppAds.min.js" currently this file decides how the ads should be looking and I dont have access to this. I guess Joachim does!

@lfaz
Copy link

lfaz commented Apr 3, 2020

ofc there might be some workaround to style this from the react part but I think it would be kinda dirty and take more time, so I presume you should handle that from the link i posted above!

@pikkuruusu
Copy link
Member Author

Thanks, I’ll check with Joachim.

@jockeF
Copy link
Contributor

jockeF commented May 13, 2020

This change is now in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants