You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[PLEASE REMOVE] See [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests) for ExecuTorch PR guidelines.
3
+
4
+
[PLEASE REMOVE] If this PR closes an issue, please add a `Fixes #<issue-id>` line.
5
+
6
+
[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: <area>" label. For a list of available release notes labels, check out [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests).
7
+
8
+
### Test plan
9
+
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.
Copy file name to clipboardexpand all lines: CONTRIBUTING.md
+15-2
Original file line number
Diff line number
Diff line change
@@ -242,14 +242,27 @@ for basics.
242
242
- Give the PR a clear and thorough description. Don't just describe what the PR
243
243
does: the diff will do that. Explain *why* you are making this change, in a
244
244
way that will make sense to someone years from now.
245
-
- Add the line `Test Plan:` (with that spelling, capitalization, and trailing
246
-
colon character), followed by lines containing repeatable instructions for
245
+
- Explain how you have tested your changes by including repeatable instructions for
247
246
testing the PR.
248
247
- If you added tests, this can be as simple as the command you used to run the
249
248
tests.
250
249
- If you tested the PR manually, include the steps and the outputs. Help a
251
250
future editor understand how to test the code that you're modifying
252
251
today.
252
+
- If your PR contains or is representative of a feature/bug fix that should be
253
+
called out in the release notes, please add a label for "Release notes: \<area\>",
254
+
where \<area\> describes which part of ExecuTorch the change pertains to, e.g.
255
+
"Release notes: runtime". Here are all of the categories:
256
+
- `Release notes: runtime`: changes related to the core runtime which loads the program methods, initializes delegates, and runs the lowered graph.
257
+
- `Release notes: exir`: changes to any internal representations, such as any edge-related dialects. Also any changes to passes that may modify the exir, such as memory planning.
258
+
- `Release notes: quantization`: changes to quantization.
259
+
- `Release notes: ops & kernels`: changes to the opset and any new / changed kernel implementations.
260
+
- `Release notes: api`: changes to public facing apis (any interfaces, pybinded runtime methods, etc.).
261
+
- `Release notes: backends`: changes to any of the backend delegates.
262
+
- `Release notes: build`: changes related to the build system, including major dependency upgrades, notable build flags, optimizations, etc.
263
+
- `Release notes: devtools`: changes to any of ExecuTorch's developer tools, for example the debugger & profiler.
264
+
- `Release notes: examples`: changes to any code under `examples/`.
265
+
- `Release notes: misc`: anything notable that doesn't belong in the above categories.
253
266
- See https://github.com/pytorch/executorch/pull/3612 for an example PR that
254
267
follows this advice.
255
268
1. Before asking for a review, ensure that all [CI (continuous integration)
0 commit comments