Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should treat tool specs as case insensitive #41

Open
JohnnyMorganz opened this issue Jan 19, 2023 · 1 comment
Open

Should treat tool specs as case insensitive #41

JohnnyMorganz opened this issue Jan 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@JohnnyMorganz
Copy link
Contributor

Right now, aftman treats e.g. UpliftGames/[email protected] and upliftgames/[email protected] as separate tools and will install the latter again even if the former is already installed. They should instead be treated as the same tool.

I'm unsure however if there are any negative side effects for it being case insensitive
@LPGhatguy LPGhatguy added the enhancement New feature or request label Jan 20, 2023
@LPGhatguy
Copy link
Owner

Yeah, this is definitely something to fix. We can use manually implement PartialEq and Hash to use lowercase variants of names while preserving the original case.

@SamButNotSam SamButNotSam mentioned this issue Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LPGhatguy @JohnnyMorganz