Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Makie #315

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

WIP: Makie #315

wants to merge 19 commits into from

Conversation

jtravs
Copy link
Contributor

@jtravs jtravs commented Feb 9, 2023

This switches plotting to Makie.

In this initial state, I think it is complete but it is fairly untested (and also only tested on 1.9.0beta3). There are numerous small issues with the text display, and I haven't worked out how to automatically set the figure resolution and font size. But it works quite well.

The Makie DataInspector is quite nice for getting numbers from the plots, and zooming etc. works if you know the Makie system. Also it is easy to make nice 3d plots, like this new spectrogram version:
test

Also, it doesn't crash long-running Julia sessions on the mac!

@chrisbrahms
Copy link
Collaborator

Very nice! This takes a lot less code than I thought it would. The figure size definitely needs some thought. On my 1080p external screen at home everything is enormous, and some figures have the wrong aspect ratio.

I'm also finding that I can't import Luna and PyPlot simultaneously--it crashes Julia in all of my attempts. It seems that GLMakie interferes with the PyPlot backend in some horrible way.

The CI will need some extra lines to make the import work: https://discourse.julialang.org/t/ci-fails-to-build-glmakie-dependency/80125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants