Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pain-points of isolation and how to fix them #261

Open
miguelgondu opened this issue Sep 26, 2024 · 5 comments
Open

The pain-points of isolation and how to fix them #261

miguelgondu opened this issue Sep 26, 2024 · 5 comments
Assignees

Comments

@miguelgondu
Copy link
Collaborator

No description provided.

@miguelgondu
Copy link
Collaborator Author

miguelgondu commented Sep 26, 2024

  • conda env creation is silent (and thus also fails silently at times). After this, the user is left with an ill state. (The config.rc is lying).
    • The conda env creation should be forwarded to the user.

@miguelgondu
Copy link
Collaborator Author

  • We end up creating the conda envs ourselves

@miguelgondu
Copy link
Collaborator Author

  • Debugging is impossible.

@miguelgondu
Copy link
Collaborator Author

@samuelstanton

@miguelgondu
Copy link
Collaborator Author

miguelgondu commented Oct 2, 2024

With PR #270 I added optional dependencies for most of the black boxes.

Of the ones we currently test, almost all of then can be run by just saying e.g. pip install poli[foldx] or pip install poli[tdc]. The tox.ini test environments have been changed to not run conda but rather install the package this way.

The only black box that doesn't run is rasp, since it has a strong dependency on openmm which is only available through conda.

As a side note, this cuts CI time by more than half in most cases. I think we should still test that the envs build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants