Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro stack traces in source offsets #140

Open
Mercerenies opened this issue Feb 15, 2023 · 1 comment
Open

Macro stack traces in source offsets #140

Mercerenies opened this issue Feb 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Mercerenies
Copy link
Owner

Currently, any errors during macro expansion or that occur due to code produced by a macro expansion are reported to occur at the site of the original macro call. Ideally, we could make SourceOffset more complex and able to handle macro stacks. So the error could actually say "error occurred at line X, during macro expansion of macro Y at line Z, during macro expansion of ..." and so on.
@Mercerenies Mercerenies added the enhancement New feature or request label Feb 15, 2023
@Mercerenies
Copy link
Owner Author

Point in the code where the source offset is set during macro expansion right now: https://github.com/Mercerenies/gdlisp/blob/6feb3fb/src/ir/incremental.rs#L112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mercerenies