You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using mm-snap watch, the CLI will rebuild the Snap twice after detecting a change in the source code. Once because the source file changed and once again because rebuilding causes snap.manifest.json to be updated.
We should look into minimizing this and strictly rebuilding when necessary.
The text was updated successfully, but these errors were encountered:
We use webpack to watch the filesystem including the manifest
We run the webpack plugin to update the manifest outside of webpack build process.
Webpack notices that the manifest has been updated and rebuilds the bundle
I've tried the following:
Webpack has no way to conditionally watch files
Webpack has no way to abort the build for the second change
Debouncing the build by collating modified files does not work
Emitting the updated manifest using webpack APIs does not work
What we could do is to rewrite much of the snaps-cli to manually watch the manifest outside webpack and manually execute a webpack build on manifest update.
For the time being we decided to timebox this issue and not do it at this time.
When using
mm-snap watch
, the CLI will rebuild the Snap twice after detecting a change in the source code. Once because the source file changed and once again because rebuilding causessnap.manifest.json
to be updated.We should look into minimizing this and strictly rebuilding when necessary.
The text was updated successfully, but these errors were encountered: