[Bug] @milkdown/plugin-trailing has a bug? If I config shouldAppend => return true, the browser crashes!

[yswang0927]

Initial checklist

• I agree to follow the code of conduct
• I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected packages and versions

v7.6.3

Link to runnable example

No response

Steps to reproduce

When config @milkdown/plugin-trailing :

shouldAppend: (lastNode) => {
      if (!lastNode) return false;
      return true;
}

and then visit milkdown editor, my Chrome(v133) browser crashes.

But use default config, my Chrome browser is ok, why?

// default config
shouldAppend: (lastNode) => {
      if (!lastNode) return false
      if (['heading', 'paragraph'].includes(lastNode.type.name)) return false
      return true
}

Expected behavior

When config shouldAppend: ()=>return true , milkdown editor should be ok, and always append blank node at the end of the document.

Actual behavior

Browser crashes!

Runtime

Chrome

OS

Windows

Build and bundle tools

No response

[Saul-Mirone]

It's not a bug. It's how prosemirror work. You shouldn't configure it to return true.

1. Editor run a update event.
2. Update event add a node at the end, which will trigger another update event.
3. Another node added at the end, which will trigger more update events.

I don't know what you're implementing, but you shouldn't configure it to return true.

[yswang0927]

It's not a bug. It's how prosemirror work. You shouldn't configure it to return true.

1. Editor run a update event.
2. Update event add a node at the end, which will trigger another update event.
3. Another node added at the end, which will trigger more update events.

I don't know what you're implementing, but you shouldn't configure it to return true.

I want to always automatically append a blank line at the end of the document.

For example: https://milkdown.dev/playground , it doesn't have a blank line at the end, and I have to manually tap a newline when I need to continue typing.

[Saul-Mirone]

you should return false when last line is an empty paragraph