-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sui-field-count: const instead of fn and use it in sui-indexer-alt #20143
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gegaowp -- the change from a function to a constant looks good, but the integration needs some tweaking, PTAL.
cf162cf
to
95b615e
Compare
95b615e
to
a256fc7
Compare
a256fc7
to
92e26d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller suggestions (and a spurious extra commit), but this is shaping up in a positive direction, thanks @gegaowp !
92e26d7
to
b511875
Compare
b511875
to
5625029
Compare
5625029
to
b99efde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gegaowp ! Just one comment to avoid the duplication for calculating max_chunk_rows
(without allowing people to override it).
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.