Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Controlled collapsible component chevron not collapsing #20479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterwangsc
Copy link

Description

Collapsing the switch accounts submenu after selecting a different account will not properly collapse the downward chevron (see video):

https://www.loom.com/share/eb2249e49d6148e08b1037b88b2baf8b

Changelog:

  • The right chevron is replaced with the down chevron rotated 90 degrees, to reduce the number of image imports on this collapsible.
  • A css transition animation was added to the rotation so that it moves between rotations
  • The collapsible is removed from the active wallet display, because why would you ever want to collapse it?...
  • Fixed the controlled component Collapsible to respond to changes to its isOpen prop by changing its internal state.
  • Moved the google background image to center because there are compression artifacts near the edges of the image

Test plan

See video:

https://loom.com/share/2dd0e386877e47daa0c9ca020afba394


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@peterwangsc peterwangsc requested a review from a team as a code owner December 2, 2024 08:29
@peterwangsc peterwangsc requested review from pchrysochoidis and mystieanwaya and removed request for a team December 2, 2024 08:29
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit December 2, 2024 08:29 Inactive
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 8:30am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Skipped (Inspect) Dec 2, 2024 8:30am
sui-kiosk ⬜️ Skipped (Inspect) Dec 2, 2024 8:30am
sui-typescript-docs ⬜️ Skipped (Inspect) Dec 2, 2024 8:30am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant