Remove the direct dependency from sui-core to sui-move-build
#20706
+348
−316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
👍
FWIW, another approach that may have been simpler/more mechanical would have been to pull out the sui-core::test_utils into their own crate which depends on sui-core and sui-move-build and is itself a dev-dependency of all the other crates that were depending on sui-core for this functionality before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
sui-move-buildis linked intosui-coreas a normal dependency. The only reason for this is that some of thesui-coretesting utilities depend onsui-move-buildand some other crates depend on thesui-coretesting utilities. This PR cleans this up a bit so that the testing infrastructure that depends onsui-move-buildis not re-exported, and thereforesui-move-buildonly needs to be a dev-dependency ofsui-core.Specifically, I split the
sui_core::test_utilscode that is only used inside ofsui-coreoff intosui_core::unit_test_utils, and gated this file behind#[cfg(test)]. I then moved the tiny bit of shared testing code that usessui-move-buildintosui_move_build::test_utils.Similarly, I split off some of
sui_core::authority::authority_test_utilsintosui_core::authority::auth_unit_test_utils.Test plan
Since this just involves moving things around, if everything builds and the existing tests pass I will consider it adequately tested.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.