Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #39

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open

Development #39

wants to merge 75 commits into from

Conversation

hzfywhn
Copy link
Collaborator

@hzfywhn hzfywhn commented Jan 23, 2025

There has been a lot of changes since last merge. Open a PR to merge development into master.

AnonNick and others added 22 commits November 13, 2024 11:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
PFE uppdates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Apex Coupling to GR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Engage updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Dev engage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Dev engage test
The new set (15 element array) of ring parameters is not stable in most cases, revert it back to the old set (21 element array).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Change ring average parameters

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Development

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Stability parameters

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Bug fixes for Pleiades resources, TGCMDATA env variable, Stability parameters

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Rewrite oplus

The oplus module is rewritten to split the calculation independent of O+ sub-cycling. This may help speed up the model when there are a lot of O+ sub-cycling.

* Reorganize for clarity

Some post-processing calculations are reorganized for better clarity.

* Code cleanup

Some calculations are rearranged to better reflect the logic. Merge loops and move addfld calls to the end of the subroutine.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Duff et al. (2003) formula is now implemented as suggested by Sheng et al. (2017). A new input parameter "duff" is introduced to switch between the new rate (6.2e-12*tn/300, temperature dependent) and the old rate (5e-12, constant). We still need to decide which one to be used as the default. Reviewed by Kevin.
There was a dimension mismatch overlooked in previous commits. Correct it here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change output variables and their descriptions

Modified the description of DT_COOL. Change default behavior of saving UI_ExB to include SAPS drifts when SAPS is on. The ion drift without SAPS can be saved separately as UI_wo_SAPS. In addition, the lower bound of SAPS calculation was incorrectly set as Kp=1 in previous versions. Correct it to Kp=0 here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
File permissions change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Bugfix for dimension mismatch
@phamkh
Copy link
Collaborator

phamkh commented Jan 23, 2025

I would wait until we confirm the omega pole fix and oneway fix.

hzfywhn and others added 4 commits January 24, 2025 09:35
The apex coordinate calculation is now based on IGRF14. Thanks to @caihuhu-space
The calculation of conductivities is refactored for clarity. The new code should produce nearly the same result (up to round-off error) as the old code.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Update apex using IGRF14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Rewrite lamdas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants