-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development #39
Open
hzfywhn
wants to merge
75
commits into
master
Choose a base branch
from
development
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Development #39
+4,093
−3,192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The altitudinal decreasing rate and transition altitude are added as additional input parameters for O+ diffusion correction. Together added are the spatially dependent O+ floor which is slightly modified from TIEGCM 2.0
PFE uppdates
Apex Coupling to GR
Engage updates
Dev engage
Dev engage test
The new set (15 element array) of ring parameters is not stable in most cases, revert it back to the old set (21 element array).
Change ring average parameters
Development
Stability parameters
Bug fixes for Pleiades resources, TGCMDATA env variable, Stability parameters
* Rewrite oplus The oplus module is rewritten to split the calculation independent of O+ sub-cycling. This may help speed up the model when there are a lot of O+ sub-cycling. * Reorganize for clarity Some post-processing calculations are reorganized for better clarity. * Code cleanup Some calculations are rearranged to better reflect the logic. Merge loops and move addfld calls to the end of the subroutine.
Duff et al. (2003) formula is now implemented as suggested by Sheng et al. (2017). A new input parameter "duff" is introduced to switch between the new rate (6.2e-12*tn/300, temperature dependent) and the old rate (5e-12, constant). We still need to decide which one to be used as the default. Reviewed by Kevin.
There was a dimension mismatch overlooked in previous commits. Correct it here.
* Change output variables and their descriptions Modified the description of DT_COOL. Change default behavior of saving UI_ExB to include SAPS drifts when SAPS is on. The ion drift without SAPS can be saved separately as UI_wo_SAPS. In addition, the lower bound of SAPS calculation was incorrectly set as Kp=1 in previous versions. Correct it to Kp=0 here.
File permissions change
Bugfix for dimension mismatch
I would wait until we confirm the omega pole fix and oneway fix. |
The apex coordinate calculation is now based on IGRF14. Thanks to @caihuhu-space
The calculation of conductivities is refactored for clarity. The new code should produce nearly the same result (up to round-off error) as the old code.
Update apex using IGRF14
Rewrite lamdas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a lot of changes since last merge. Open a PR to merge development into master.